Re: [PATCH] net: l2tp: fix reversed udp6 checksum flags

2016-05-01 Thread David Miller
From: Wang Shanker Date: Fri, 29 Apr 2016 01:29:43 +0800 > This patch fixes a bug which causes the behavior of whether to ignore > udp6 checksum of udp6 encapsulated l2tp tunnel contrary to what > userspace program requests. > > When the flag `L2TP_ATTR_UDP_ZERO_CSUM6_RX` is set by userspace, it

Re: [PATCH] net: l2tp: fix reversed udp6 checksum flags

2016-04-29 Thread Wang Shanker
Is there any further suggestion or review? > 在 2016年4月29日,03:25,Wang Shanker 写道: > > I think this is a logic error, rather than a change to the default > UDP checksum setting. As expected, take rx for example, the flag > `L2TP_ATTR_UDP_ZERO_CSUM6_RX` is not set by default, and udp6 > checksum

Re: [PATCH] net: l2tp: fix reversed udp6 checksum flags

2016-04-28 Thread Wang Shanker
I think this is a logic error, rather than a change to the default UDP checksum setting. As expected, take rx for example, the flag `L2TP_ATTR_UDP_ZERO_CSUM6_RX` is not set by default, and udp6 checksum will be checked by default. The fact is that, not setting `L2TP_ATTR_UDP_ZERO_CSUM6_RX` leads

Re: [PATCH] net: l2tp: fix reversed udp6 checksum flags

2016-04-28 Thread James Chapman
Some additional background on this: Wang found this when configuring l2tp tunnels using "ip l2tp" between two systems and then one system was upgraded. The tunnel failed to pass data because one side had UDP checksums enabled and the other now had them disabled. It seems kernel changes related to U

[PATCH] net: l2tp: fix reversed udp6 checksum flags

2016-04-28 Thread Wang Shanker
This patch fixes a bug which causes the behavior of whether to ignore udp6 checksum of udp6 encapsulated l2tp tunnel contrary to what userspace program requests. When the flag `L2TP_ATTR_UDP_ZERO_CSUM6_RX` is set by userspace, it is expected that udp6 checksums of received packets of the l2tp tunn

[PATCH] net: l2tp: fix reversed udp6 checksum flags

2016-04-28 Thread Wang Shanker
This patch fixes a bug which causes the behavior of whether to ignore udp6 checksum of udp6 encapsulated l2tp tunnel contrary to what userspace program requests. When the flag `L2TP_ATTR_UDP_ZERO_CSUM6_RX` is set by userspace, it is expected that udp6 checksums of received packets of the l2tp tunn