Re: [PATCH] net: korina: remove busy skb free

2020-12-14 Thread Vincent Stehlé
On Mon, Dec 14, 2020 at 01:08:32PM -0800, Jakub Kicinski wrote: > On Mon, 14 Dec 2020 11:03:12 +0100 Julian Wiedmann wrote: > > > diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c > > > index bf48f0ded9c7d..9d84191de6824 100644 > > > --- a/drivers/net/ethernet/korina.c > >

Re: [PATCH] net: korina: remove busy skb free

2020-12-14 Thread Vincent Stehlé
On Mon, Dec 14, 2020 at 11:03:12AM +0100, Julian Wiedmann wrote: > On 13.12.20 18:20, Vincent Stehlé wrote: ... > > @@ -216,7 +216,6 @@ static int korina_send_packet(struct sk_buff *skb, > > struct net_device *dev) > > netif_stop_queue(dev); > > else { > >

Re: [PATCH] net: korina: remove busy skb free

2020-12-14 Thread Jakub Kicinski
On Mon, 14 Dec 2020 11:03:12 +0100 Julian Wiedmann wrote: > > diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c > > index bf48f0ded9c7d..9d84191de6824 100644 > > --- a/drivers/net/ethernet/korina.c > > +++ b/drivers/net/ethernet/korina.c > > @@ -216,7 +216,6 @@ static int k

Re: [PATCH] net: korina: remove busy skb free

2020-12-14 Thread Julian Wiedmann
On 13.12.20 18:20, Vincent Stehlé wrote: > The ndo_start_xmit() method must not attempt to free the skb to transmit > when returning NETDEV_TX_BUSY. Fix the korina_send_packet() function > accordingly. > > Fixes: ef11291bcd5f ("Add support the Korina (IDT RC32434) Ethernet MAC") > Signed-off-by: V

[PATCH] net: korina: remove busy skb free

2020-12-13 Thread Vincent Stehlé
The ndo_start_xmit() method must not attempt to free the skb to transmit when returning NETDEV_TX_BUSY. Fix the korina_send_packet() function accordingly. Fixes: ef11291bcd5f ("Add support the Korina (IDT RC32434) Ethernet MAC") Signed-off-by: Vincent Stehlé Cc: David S. Miller Cc: Jakub Kicinsk