Re: [PATCH] net: ipv6: check route protocol when deleting routes

2017-04-25 Thread David Ahern
On 4/24/17 3:48 AM, Lorenzo Colitti wrote: > For non-stable kernels, it seems that the proper fix would be: > > 1. Ensure that when an RA creates a route, it properly sets > rtm_protocol at time of route creation. > 2. When we dump routes to userspace, we don't overwrite the rtm_protocol. +1

Re: [PATCH] net: ipv6: check route protocol when deleting routes

2017-04-24 Thread Lorenzo Colitti
On Fri, Dec 16, 2016 at 5:30 PM, Mantas Mikulėnas wrote: > The protocol field is checked when deleting IPv4 routes, but ignored for > IPv6, which causes problems with routing daemons accidentally deleting > externally set routes (observed by multiple bird6 users). > > This can be verified using `i

Re: [PATCH] net: ipv6: check route protocol when deleting routes

2016-12-17 Thread David Miller
From: Mantas Mikulėnas Date: Fri, 16 Dec 2016 10:30:59 +0200 > The protocol field is checked when deleting IPv4 routes, but ignored for > IPv6, which causes problems with routing daemons accidentally deleting > externally set routes (observed by multiple bird6 users). > > This can be verified us

[PATCH] net: ipv6: check route protocol when deleting routes

2016-12-16 Thread Mantas Mikulėnas
The protocol field is checked when deleting IPv4 routes, but ignored for IPv6, which causes problems with routing daemons accidentally deleting externally set routes (observed by multiple bird6 users). This can be verified using `ip -6 route del proto something`. Signed-off-by: Mantas Mikulėnas