Hi David,
Quoting David Miller :
From: "Gustavo A. R. Silva"
Date: Thu, 4 May 2017 14:44:16 -0500
@@ -389,6 +389,12 @@ static int sk_diag_fill(struct sock *sk,
struct sk_buff *skb,
nlmsg_flags, unlh, net_admin);
}
+/*
+ * Ignore the position of the argum
From: "Gustavo A. R. Silva"
Date: Thu, 4 May 2017 14:44:16 -0500
> @@ -389,6 +389,12 @@ static int sk_diag_fill(struct sock *sk, struct sk_buff
> *skb,
> nlmsg_flags, unlh, net_admin);
> }
>
> +/*
> + * Ignore the position of the arguments req->id.idiag_dport a
Add code comment to make it clear that the position of the arguments
req->id.idiag_dport and req->id.idiag_sport is a locked in behavior
and it should not be changed.
Addresses-Coverity-ID: 1357474
Cc: David Miller
Cc: Joe Perches
Signed-off-by: Gustavo A. R. Silva
---
net/ipv4/inet_diag.c | 6
