RE: [PATCH] net: fib: fix fib_new_table() logical issue

2017-06-21 Thread YUAN Linyu
Developers; David S . Miller; YUAN Linyu > Subject: Re: [PATCH] net: fib: fix fib_new_table() logical issue > > On Wed, Jun 21, 2017 at 7:02 AM, yuan linyu wrote: > > From: yuan linyu > > > > when CONFIG_IP_MULTIPLE_TABLES defined, > > if id == RT_TABLE_LOCAL and !net

Re: [PATCH] net: fib: fix fib_new_table() logical issue

2017-06-21 Thread Cong Wang
On Wed, Jun 21, 2017 at 7:02 AM, yuan linyu wrote: > From: yuan linyu > > when CONFIG_IP_MULTIPLE_TABLES defined, > if id == RT_TABLE_LOCAL and !net->ipv4.fib_has_custom_rules, > fib_new_table() call itself to get RT_TABLE_MAIN table, > but if RT_TABLE_MAIN table not exist at this point, > this f

[PATCH] net: fib: fix fib_new_table() logical issue

2017-06-21 Thread yuan linyu
From: yuan linyu when CONFIG_IP_MULTIPLE_TABLES defined, if id == RT_TABLE_LOCAL and !net->ipv4.fib_has_custom_rules, fib_new_table() call itself to get RT_TABLE_MAIN table, but if RT_TABLE_MAIN table not exist at this point, this function will become deadloop. the solution is move RT_TABLE_MAIN