Re: [PATCH] net: fec: set mac address unconditionally

2016-09-22 Thread Uwe Kleine-König
On Thu, Sep 22, 2016 at 08:08:36AM +0200, Uwe Kleine-König wrote: > Acked-by: Uwe Kleine-König huch, cut and paste borkage: This should be Acked-by: Uwe Kleine-König of course. Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solution

Re: [PATCH] net: fec: set mac address unconditionally

2016-09-21 Thread Uwe Kleine-König
Hello, just a few nitpicks: On Wed, Sep 21, 2016 at 03:30:55PM +0200, Gavin Schenk wrote: > Fixes: 9638d19e4816 ("net: fec: add netif status check before set mac > address") This line belongs to in the S-o-B area below. > If the mac address origin is not dt, you can only safe assign a s/safe/

RE: [PATCH] net: fec: set mac address unconditionally

2016-09-21 Thread Andy Duan
From: Gavin Schenk Sent: Wednesday, September 21, 2016 9:31 PM > To: Andy Duan > Cc: netdev@vger.kernel.org; ker...@pengutronix.de; Gavin Schenk > > Subject: [PATCH] net: fec: set mac address unconditionally > > Fixes: 9638d19e4816 ("net: fec: add netif status check b

[PATCH] net: fec: set mac address unconditionally

2016-09-21 Thread Gavin Schenk
Fixes: 9638d19e4816 ("net: fec: add netif status check before set mac address") If the mac address origin is not dt, you can only safe assign a mac address after "link up" of the device. If the link is down the clocks are disabled and because of issues assigning registers when clocks are down the