RE: [PATCH] net: ethernet:fec: Consistently use SPEED_ prefix

2018-10-21 Thread Andy Duan
From: netdev-ow...@vger.kernel.org > All other calls to phy_set_max_speed() use the SPEED_ prefix. Make the > FEC driver follow this common pattern. This makes no different to > generated code since SPEED_1000 is 1000, and SPEED_100 is 100. > Please also add more information that was introduced

Re: [PATCH] net: ethernet:fec: Consistently use SPEED_ prefix

2018-10-21 Thread Sergei Shtylyov
On 20.10.2018 23:48, Andrew Lunn wrote: All other calls to phy_set_max_speed() use the SPEED_ prefix. Make the FEC driver follow this common pattern. This makes no different to Difference. generated code since SPEED_1000 is 1000, and SPEED_100 is 100. Reported-by: Corentin Labbe Signed-

[PATCH] net: ethernet:fec: Consistently use SPEED_ prefix

2018-10-20 Thread Andrew Lunn
All other calls to phy_set_max_speed() use the SPEED_ prefix. Make the FEC driver follow this common pattern. This makes no different to generated code since SPEED_1000 is 1000, and SPEED_100 is 100. Reported-by: Corentin Labbe Signed-off-by: Andrew Lunn --- drivers/net/ethernet/freescale/fec_m