Re: [PATCH] net: ethernet: support "fixed-link" DT node on nb8800 driver

2016-02-05 Thread Måns Rullgård
Andy Shevchenko writes: > On Fri, Feb 5, 2016 at 3:39 PM, Måns Rullgård wrote: >>> + if (ret < 0) { >>> + dev_err(&pdev->dev, "broken fixed-link >>> specification\n"); >> >> Line is longer than 80 chars. > > This is actually okay, though I would r

Re: [PATCH] net: ethernet: support "fixed-link" DT node on nb8800 driver

2016-02-05 Thread Andy Shevchenko
On Fri, Feb 5, 2016 at 3:39 PM, Måns Rullgård wrote: >> + if (ret < 0) { >> + dev_err(&pdev->dev, "broken fixed-link >> specification\n"); > > Line is longer than 80 chars. This is actually okay, though I would recommend to move long string literal

[PATCH] net: ethernet: support "fixed-link" DT node on nb8800 driver

2016-02-05 Thread Sebastian Frias
Signed-off-by: Sebastian Frias --- drivers/net/ethernet/aurora/nb8800.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c index ecc4a33..1353fee 100644 --- a/drivers/net/ethernet

Re: [PATCH] net: ethernet: support "fixed-link" DT node on nb8800 driver

2016-02-05 Thread Måns Rullgård
Sebastian Frias writes: > Signed-off-by: Sebastian Frias > --- > drivers/net/ethernet/aurora/nb8800.c | 19 +++ > 1 file changed, 15 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/ethernet/aurora/nb8800.c > b/drivers/net/ethernet/aurora/nb8800.c > index ecc4a33..1353