Re: [PATCH] net: ethernet: slicoss: remove redundant initialization of idx

2017-10-30 Thread Lino Sanfilippo
On 30.10.2017 19:04, Jakub Kicinski wrote: > On Sun, 29 Oct 2017 13:38:09 +, Colin King wrote: >> From: Colin Ian King >> >> Variable idx is being initialized and later on over-written by >> a new value in a do-loop without the initial value ever being >> read. Hence the initializion is redund

Re: [PATCH] net: ethernet: slicoss: remove redundant initialization of idx

2017-10-30 Thread Jakub Kicinski
On Sun, 29 Oct 2017 13:38:09 +, Colin King wrote: > From: Colin Ian King > > Variable idx is being initialized and later on over-written by > a new value in a do-loop without the initial value ever being > read. Hence the initializion is redundant and can be removed. > Cleans up clang warning

Re: [PATCH] net: ethernet: slicoss: remove redundant initialization of idx

2017-10-30 Thread Lino Sanfilippo
Hi Colin, On 29.10.2017 14:38, Colin King wrote: > From: Colin Ian King > > Variable idx is being initialized and later on over-written by > a new value in a do-loop without the initial value ever being > read. Hence the initializion is redundant and can be removed. > Cleans up clang warning: >

[PATCH] net: ethernet: slicoss: remove redundant initialization of idx

2017-10-29 Thread Colin King
From: Colin Ian King Variable idx is being initialized and later on over-written by a new value in a do-loop without the initial value ever being read. Hence the initializion is redundant and can be removed. Cleans up clang warning: drivers/net/ethernet/alacritech/slicoss.c:358:15: warning: Valu