Re: [PATCH] net: ethernet: mediatek: Fix overlapping capability bits.

2019-07-01 Thread Willem de Bruijn
On Mon, Jul 1, 2019 at 8:44 AM René van Dorst wrote: > > Quoting Willem de Bruijn : > > > On Sat, Jun 29, 2019 at 8:24 AM René van Dorst > > wrote: > >> > >> Both MTK_TRGMII_MT7621_CLK and MTK_PATH_BIT are defined as bit 10. > >> > >> This causes issues on non-MT7621 devices which has the > >> M

Re: [PATCH] net: ethernet: mediatek: Fix overlapping capability bits.

2019-07-01 Thread René van Dorst
Quoting Willem de Bruijn : On Sat, Jun 29, 2019 at 8:24 AM René van Dorst wrote: Both MTK_TRGMII_MT7621_CLK and MTK_PATH_BIT are defined as bit 10. This causes issues on non-MT7621 devices which has the MTK_PATH_BIT(MTK_ETH_PATH_GMAC1_RGMII) capability set. The wrong TRGMII setup code is exe

Re: [PATCH] net: ethernet: mediatek: Fix overlapping capability bits.

2019-06-29 Thread Willem de Bruijn
On Sat, Jun 29, 2019 at 8:24 AM René van Dorst wrote: > > Both MTK_TRGMII_MT7621_CLK and MTK_PATH_BIT are defined as bit 10. > > This causes issues on non-MT7621 devices which has the > MTK_PATH_BIT(MTK_ETH_PATH_GMAC1_RGMII) capability set. > The wrong TRGMII setup code is executed. > > Moving the

[PATCH] net: ethernet: mediatek: Fix overlapping capability bits.

2019-06-29 Thread René van Dorst
Both MTK_TRGMII_MT7621_CLK and MTK_PATH_BIT are defined as bit 10. This causes issues on non-MT7621 devices which has the MTK_PATH_BIT(MTK_ETH_PATH_GMAC1_RGMII) capability set. The wrong TRGMII setup code is executed. Moving the MTK_PATH_BIT to bit 11 fixes the issue. Fixes: 8efaa653a8a5 ("net: