Re: [PATCH] net: ethernet: cpsw-phy-sel: prefer phandle for phy sel and update binding

2018-08-09 Thread Grygorii Strashko
On 08/09/2018 05:46 AM, Tony Lindgren wrote: * Tony Lindgren [180808 13:52]: * Andrew Lunn [180808 12:02]: Do you need to handle EPROBE_DEFER here? The phandle points to a device which has not yet been loaded? I'm not sure exactly where it will be returned, maybe it is bus_find_device(),

Re: [PATCH] net: ethernet: cpsw-phy-sel: prefer phandle for phy sel and update binding

2018-08-09 Thread Tony Lindgren
* Tony Lindgren [180808 13:52]: > * Andrew Lunn [180808 12:02]: > > > > Do you need to handle EPROBE_DEFER here? The phandle points to a > > device which has not yet been loaded? I'm not sure exactly where it > > will be returned, maybe it is bus_find_device(), but i expect to see > > some handl

Re: [PATCH] net: ethernet: cpsw-phy-sel: prefer phandle for phy sel and update binding

2018-08-08 Thread Tony Lindgren
* Andrew Lunn [180808 12:02]: > > +++ b/Documentation/devicetree/bindings/net/cpsw.txt > > @@ -19,6 +19,9 @@ Required properties: > > - slaves : Specifies number for slaves > > - active_slave : Specifies the slave to use for time stamping, > > ethtool

Re: [PATCH] net: ethernet: cpsw-phy-sel: prefer phandle for phy sel and update binding

2018-08-08 Thread Andrew Lunn
> +++ b/Documentation/devicetree/bindings/net/cpsw.txt > @@ -19,6 +19,9 @@ Required properties: > - slaves : Specifies number for slaves > - active_slave : Specifies the slave to use for time stamping, > ethtool and SIOCGMIIPHY > +- cpsw-phy-sel

[PATCH] net: ethernet: cpsw-phy-sel: prefer phandle for phy sel and update binding

2018-08-08 Thread Tony Lindgren
The cpsw-phy-sel device is not a child of the cpsw interconnect target module. It lives in the system control module. Let's fix this issue by trying to use cpsw-phy-sel phandle first if it exists and if not fall back to current usage of trying to find the cpsw-phy-sel child. That way the phy sel d