Re: [PATCH] net: ethernet: ave: Fix error returns in ave_init

2020-07-21 Thread David Miller
From: Wang Hai Date: Fri, 17 Jul 2020 10:50:49 +0800 > When regmap_update_bits failed in ave_init(), calls of the functions > reset_control_assert() and clk_disable_unprepare() were missed. > Add goto out_reset_assert to do this. > > Fixes: 57878f2f4697 ("net: ethernet: ave: add support for phy-

Re: [PATCH] net: ethernet: ave: Fix error returns in ave_init

2020-07-16 Thread Kunihiko Hayashi
Hi Wang, On 2020/07/17 11:50, Wang Hai wrote: When regmap_update_bits failed in ave_init(), calls of the functions reset_control_assert() and clk_disable_unprepare() were missed. Add goto out_reset_assert to do this. Fixes: 57878f2f4697 ("net: ethernet: ave: add support for phy-mode setting of

[PATCH] net: ethernet: ave: Fix error returns in ave_init

2020-07-16 Thread Wang Hai
When regmap_update_bits failed in ave_init(), calls of the functions reset_control_assert() and clk_disable_unprepare() were missed. Add goto out_reset_assert to do this. Fixes: 57878f2f4697 ("net: ethernet: ave: add support for phy-mode setting of system controller") Reported-by: Hulk Robot Sig