Re: Re: [PATCH] net: ethernet: Fix memleak in ethoc_probe

2021-01-06 Thread dinghao . liu
> On Wed, 6 Jan 2021 18:56:23 +0800 (GMT+08:00) dinghao@zju.edu.cn > wrote: > > > I used this one for a test: > > > > > > https://patchwork.kernel.org/project/netdevbpf/patch/1609312994-121032-1-git-send-email-abaci-bug...@linux.alibaba.com/ > > > > > > I'm not getting the Fixes tag when I do

Re: [PATCH] net: ethernet: Fix memleak in ethoc_probe

2021-01-06 Thread Jakub Kicinski
On Wed, 6 Jan 2021 18:56:23 +0800 (GMT+08:00) dinghao@zju.edu.cn wrote: > > I used this one for a test: > > > > https://patchwork.kernel.org/project/netdevbpf/patch/1609312994-121032-1-git-send-email-abaci-bug...@linux.alibaba.com/ > > > > I'm not getting the Fixes tag when I download the mbo

Re: Re: [PATCH] net: ethernet: Fix memleak in ethoc_probe

2021-01-06 Thread dinghao . liu
> On Mon, 28 Dec 2020 16:14:17 -0500 Konstantin Ryabitsev wrote: > > On Mon, Dec 28, 2020 at 01:05:26PM -0800, Florian Fainelli wrote: > > > On 12/28/2020 12:23 PM, Konstantin Ryabitsev wrote: > > > > On Thu, Dec 24, 2020 at 01:57:40PM -0800, Florian Fainelli wrote: > > > Konstantin, would

Re: [PATCH] net: ethernet: Fix memleak in ethoc_probe

2020-12-30 Thread Jakub Kicinski
On Mon, 28 Dec 2020 16:14:17 -0500 Konstantin Ryabitsev wrote: > On Mon, Dec 28, 2020 at 01:05:26PM -0800, Florian Fainelli wrote: > > On 12/28/2020 12:23 PM, Konstantin Ryabitsev wrote: > > > On Thu, Dec 24, 2020 at 01:57:40PM -0800, Florian Fainelli wrote: > > Konstantin, would you be wi

Re: [PATCH] net: ethernet: Fix memleak in ethoc_probe

2020-12-28 Thread Konstantin Ryabitsev
On Mon, Dec 28, 2020 at 01:05:26PM -0800, Florian Fainelli wrote: > On 12/28/2020 12:23 PM, Konstantin Ryabitsev wrote: > > On Thu, Dec 24, 2020 at 01:57:40PM -0800, Florian Fainelli wrote: > Konstantin, would you be willing to mod the kernel.org instance of > patchwork to populate Fixes

Re: [PATCH] net: ethernet: Fix memleak in ethoc_probe

2020-12-28 Thread Konstantin Ryabitsev
On Thu, Dec 24, 2020 at 01:57:40PM -0800, Florian Fainelli wrote: > >> Konstantin, would you be willing to mod the kernel.org instance of > >> patchwork to populate Fixes tags in the generated mboxes? > > > > I'd really rather not -- we try not to diverge from project upstream if at > > all > > p

Re: [PATCH] net: ethernet: Fix memleak in ethoc_probe

2020-12-28 Thread Florian Fainelli
On 12/28/2020 12:23 PM, Konstantin Ryabitsev wrote: > On Thu, Dec 24, 2020 at 01:57:40PM -0800, Florian Fainelli wrote: Konstantin, would you be willing to mod the kernel.org instance of patchwork to populate Fixes tags in the generated mboxes? >>> >>> I'd really rather not -- we try n

Re: [PATCH] net: ethernet: Fix memleak in ethoc_probe

2020-12-24 Thread Florian Fainelli
On 12/24/2020 10:06 AM, Konstantin Ryabitsev wrote: > On Wed, Dec 23, 2020 at 05:41:46PM -0800, Jakub Kicinski wrote: > Does patchwork not automagically add Fixes: lines from full up emails? > That seems like a reasonable automation. Looks like it's been a TODO for 3 years no

Re: [PATCH] net: ethernet: Fix memleak in ethoc_probe

2020-12-24 Thread Konstantin Ryabitsev
On Wed, Dec 23, 2020 at 05:41:46PM -0800, Jakub Kicinski wrote: > > >> Does patchwork not automagically add Fixes: lines from full up emails? > > >> That seems like a reasonable automation. > > > > > > Looks like it's been a TODO for 3 years now: > > > > > > https://github.com/getpatchwork/patc

Re: [PATCH] net: ethernet: Fix memleak in ethoc_probe

2020-12-23 Thread Jakub Kicinski
On Wed, 23 Dec 2020 14:17:29 -0800 Florian Fainelli wrote: > On 12/23/2020 1:11 PM, Jakub Kicinski wrote: > > On Wed, 23 Dec 2020 22:00:44 +0100 Andrew Lunn wrote: > >> On Wed, Dec 23, 2020 at 12:32:18PM -0800, Jakub Kicinski wrote: > >>> On Wed, 23 Dec 2020 16:33:04 +0100 Andrew Lunn wrote:

Re: [PATCH] net: ethernet: Fix memleak in ethoc_probe

2020-12-23 Thread Florian Fainelli
On 12/23/2020 1:11 PM, Jakub Kicinski wrote: > On Wed, 23 Dec 2020 22:00:44 +0100 Andrew Lunn wrote: >> On Wed, Dec 23, 2020 at 12:32:18PM -0800, Jakub Kicinski wrote: >>> On Wed, 23 Dec 2020 16:33:04 +0100 Andrew Lunn wrote: On Wed, Dec 23, 2020 at 07:06:12PM +0800, Dinghao Liu wrote:

Re: [PATCH] net: ethernet: Fix memleak in ethoc_probe

2020-12-23 Thread Jakub Kicinski
On Wed, 23 Dec 2020 22:00:44 +0100 Andrew Lunn wrote: > On Wed, Dec 23, 2020 at 12:32:18PM -0800, Jakub Kicinski wrote: > > On Wed, 23 Dec 2020 16:33:04 +0100 Andrew Lunn wrote: > > > On Wed, Dec 23, 2020 at 07:06:12PM +0800, Dinghao Liu wrote: > > > > When mdiobus_register() fails, priv->mdio

Re: [PATCH] net: ethernet: Fix memleak in ethoc_probe

2020-12-23 Thread Andrew Lunn
On Wed, Dec 23, 2020 at 12:32:18PM -0800, Jakub Kicinski wrote: > On Wed, 23 Dec 2020 16:33:04 +0100 Andrew Lunn wrote: > > On Wed, Dec 23, 2020 at 07:06:12PM +0800, Dinghao Liu wrote: > > > When mdiobus_register() fails, priv->mdio allocated > > > by mdiobus_alloc() has not been freed, which leads

Re: [PATCH] net: ethernet: Fix memleak in ethoc_probe

2020-12-23 Thread Jakub Kicinski
On Wed, 23 Dec 2020 16:33:04 +0100 Andrew Lunn wrote: > On Wed, Dec 23, 2020 at 07:06:12PM +0800, Dinghao Liu wrote: > > When mdiobus_register() fails, priv->mdio allocated > > by mdiobus_alloc() has not been freed, which leads > > to memleak. > > > > Signed-off-by: Dinghao Liu > > Fixes: bfa4

Re: [PATCH] net: ethernet: Fix memleak in ethoc_probe

2020-12-23 Thread Andrew Lunn
On Wed, Dec 23, 2020 at 07:06:12PM +0800, Dinghao Liu wrote: > When mdiobus_register() fails, priv->mdio allocated > by mdiobus_alloc() has not been freed, which leads > to memleak. > > Signed-off-by: Dinghao Liu Fixes: bfa49cfc5262 ("net/ethoc: fix null dereference on error exit path") Reviewe

[PATCH] net: ethernet: Fix memleak in ethoc_probe

2020-12-23 Thread Dinghao Liu
When mdiobus_register() fails, priv->mdio allocated by mdiobus_alloc() has not been freed, which leads to memleak. Signed-off-by: Dinghao Liu --- drivers/net/ethernet/ethoc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ethoc.c b/drivers/net/ethernet