Re: [PATCH] net: dsa: mv88e6xxx: make unexported functions static

2016-06-09 Thread Ben Dooks
On 09/06/16 13:47, Vivien Didelot wrote: > Hi Ben, > > Vivien Didelot writes: > >> Most of them are fixed or being handled in net-next. >> >> I don't know if net should diverge or if it can live with these >> warnings... > > In fact I have a series in net-next fixing a few checkpatch.pl issue.

Re: [PATCH] net: dsa: mv88e6xxx: make unexported functions static

2016-06-09 Thread Vivien Didelot
Hi Ben, Vivien Didelot writes: > Most of them are fixed or being handled in net-next. > > I don't know if net should diverge or if it can live with these > warnings... In fact I have a series in net-next fixing a few checkpatch.pl issue. If you don't mind I can rebase your fix and integrate the

Re: [PATCH] net: dsa: mv88e6xxx: make unexported functions static

2016-06-09 Thread Vivien Didelot
Hi Ben, Ben Dooks writes: > The driver has a number of functions that are not exported or > declared elsewhere, so make them static to avoid the following > warnings from sparse: > > drivers/net/dsa/mv88e6xxx.c:113:5: warning: symbol 'mv88e6xxx_reg_read' was > not declared. Should it be static?

[PATCH] net: dsa: mv88e6xxx: make unexported functions static

2016-06-09 Thread Ben Dooks
The driver has a number of functions that are not exported or declared elsewhere, so make them static to avoid the following warnings from sparse: drivers/net/dsa/mv88e6xxx.c:113:5: warning: symbol 'mv88e6xxx_reg_read' was not declared. Should it be static? drivers/net/dsa/mv88e6xxx.c:167:5: warn