On 09/12/2018 03:32 PM, Andrew Lunn wrote:
>> But the DT should correctly describe the hardware, if it doesn't, it's
>> just broken.
>
> It is more subtle than that. It can be broken, yet work, because it
> contains information which we don't use. I really expect there will be
> cut/paste errors,
> But the DT should correctly describe the hardware, if it doesn't, it's
> just broken.
It is more subtle than that. It can be broken, yet work, because it
contains information which we don't use. I really expect there will be
cut/paste errors, meaning the more specific compatible is sometimes
wro
On 09/12/2018 02:47 PM, Andrew Lunn wrote:
> On Wed, Sep 12, 2018 at 10:38:41AM +0200, Marek Vasut wrote:
>> On 09/12/2018 02:46 AM, Andrew Lunn wrote:
>>> On Wed, Sep 12, 2018 at 02:04:54AM +0200, Marek Vasut wrote:
On 09/12/2018 01:32 AM, Andrew Lunn wrote:
>> compatible = "marvell,mv88e
On Wed, Sep 12, 2018 at 10:38:41AM +0200, Marek Vasut wrote:
> On 09/12/2018 02:46 AM, Andrew Lunn wrote:
> > On Wed, Sep 12, 2018 at 02:04:54AM +0200, Marek Vasut wrote:
> >> On 09/12/2018 01:32 AM, Andrew Lunn wrote:
> compatible = "marvell,mv88e6352", "marvell,mv88e6085";
> >>>
> >>> Just "
On 09/12/2018 02:46 AM, Andrew Lunn wrote:
> On Wed, Sep 12, 2018 at 02:04:54AM +0200, Marek Vasut wrote:
>> On 09/12/2018 01:32 AM, Andrew Lunn wrote:
compatible = "marvell,mv88e6352", "marvell,mv88e6085";
>>>
>>> Just "marvell,mv88e6085";
>>>
>>> Please take a look at all the other DT files
On Wed, Sep 12, 2018 at 02:04:54AM +0200, Marek Vasut wrote:
> On 09/12/2018 01:32 AM, Andrew Lunn wrote:
> >> compatible = "marvell,mv88e6352", "marvell,mv88e6085";
> >
> > Just "marvell,mv88e6085";
> >
> > Please take a look at all the other DT files using the Marvell
> > chips. You will only e
On 09/12/2018 01:32 AM, Andrew Lunn wrote:
>> compatible = "marvell,mv88e6352", "marvell,mv88e6085";
>
> Just "marvell,mv88e6085";
>
> Please take a look at all the other DT files using the Marvell
> chips. You will only ever find "marvell,mv88e6085" or
> "marvell,mv88e6190", because everything i
On 9/11/2018 6:32 PM, Andrew Lunn wrote:
> Please take a look at all the other DT files using the Marvell
> chips. You will only ever find "marvell,mv88e6085" or
> "marvell,mv88e6190", because everything is compatible to one of these
> two.
To extend what Andrew stated above,
Documentation/device
> compatible = "marvell,mv88e6352", "marvell,mv88e6085";
Just "marvell,mv88e6085";
Please take a look at all the other DT files using the Marvell
chips. You will only ever find "marvell,mv88e6085" or
"marvell,mv88e6190", because everything is compatible to one of these
two.
Andrew
On 09/12/2018 01:12 AM, Andrew Lunn wrote:
> On Wed, Sep 12, 2018 at 12:15:36AM +0200, Marek Vasut wrote:
>> Add DT compatible string for MV88E6352 switch.
>>
>> Signed-off-by: Marek Vasut
>> Cc: Andrew Lunn
>> ---
>> drivers/net/dsa/mv88e6xxx/chip.c | 4
>> 1 file changed, 4 insertions(+)
On Wed, Sep 12, 2018 at 12:15:36AM +0200, Marek Vasut wrote:
> Add DT compatible string for MV88E6352 switch.
>
> Signed-off-by: Marek Vasut
> Cc: Andrew Lunn
> ---
> drivers/net/dsa/mv88e6xxx/chip.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/dsa/mv88e6xxx/chip.c
Add DT compatible string for MV88E6352 switch.
Signed-off-by: Marek Vasut
Cc: Andrew Lunn
---
drivers/net/dsa/mv88e6xxx/chip.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index e07838430d16..15427380e32e 100644
---
12 matches
Mail list logo
