Re: [PATCH] net: cavium: liquidio: fix check for in progress flag

2016-02-13 Thread David Miller
From: Colin King Date: Fri, 5 Feb 2016 16:30:39 + > From: Colin Ian King > > smatch detected a suspicious looking bitop condition: > > drivers/net/ethernet/cavium/liquidio/lio_main.c:2529 > handle_timestamp() warn: suspicious bitop condition > > (skb_shinfo(skb)->tx_flags | SKBTX_IN_PR

[PATCH] net: cavium: liquidio: fix check for in progress flag

2016-02-05 Thread Colin King
From: Colin Ian King smatch detected a suspicious looking bitop condition: drivers/net/ethernet/cavium/liquidio/lio_main.c:2529 handle_timestamp() warn: suspicious bitop condition (skb_shinfo(skb)->tx_flags | SKBTX_IN_PROGRESS is always non-zero, so the logic is definitely not correct. Use &