Re: [PATCH] net: atlantic: Remove unnecessary conversion to bool

2020-11-07 Thread Jakub Kicinski
On Fri, 6 Nov 2020 10:57:59 +0800 xiakaixu1...@gmail.com wrote: > - cfg->is_qos = (tcs != 0 ? true : false); > + cfg->is_qos = (tcs != 0); !!tcs

[PATCH] net: atlantic: Remove unnecessary conversion to bool

2020-11-05 Thread xiakaixu1987
From: Kaixu Xia The '!=' expression itself is bool, no need to convert it to bool. Fix the following coccicheck warning: ./drivers/net/ethernet/aquantia/atlantic/aq_nic.c:1477:34-39: WARNING: conversion to bool not needed here Reported-by: Tosk Robot Signed-off-by: Kaixu Xia --- drivers/net