> Patch timing is sometimes surprising!
Indeed it.
>
> Not sure at all if it can be an issue, but I also noted that the order of
> 'pci_release_regions()' and 'free_netdev()' is in reverse
> order in the 'aq_pci_remove()' function.
> I don't know if done on purpose and/or needed, so I've left
Le 08/05/2018 à 09:19, Igor Russkikh a écrit :
This was just submitted yesterday and is already accepted in netdev by David:
http://patchwork.ozlabs.org/patch/909746/
Thanks!
BR, Igor
Patch timing is sometimes surprising!
Not sure at all if it can be an issue, but I also noted that the ord
Hi Christophe,
On 08.05.2018 09:39, Christophe JAILLET wrote:
> The position of 2 labels should be swapped in order to release resources
> in the correct order and avoid leaks.
>
> kfree(self->aq_hw);
> err_ioremap:
> free_netdev(ndev);
> -err_pci_func:
> - pci_release_regions(p
The position of 2 labels should be swapped in order to release resources
in the correct order and avoid leaks.
Fixes: 23ee07ad3c2f ("net: aquantia: Cleanup pci functions module")
Signed-off-by: Christophe JAILLET
---
The order of 'pci_release_regions()' and 'free_netdev()' is in reverse
order in
