Re: [PATCH] net: always use icmp{,v6}_ndo_send from ndo_start_xmit

2021-02-26 Thread Willem de Bruijn
On Fri, Feb 26, 2021 at 7:42 PM Jason A. Donenfeld wrote: > > On Sat, Feb 27, 2021 at 12:29 AM Willem de Bruijn > wrote: > > > > On Fri, Feb 26, 2021 at 5:39 PM Jason A. Donenfeld wrote: > > > > > > On Fri, Feb 26, 2021 at 10:25 PM Willem de Bruijn > > > wrote: > > > > > > > > On Thu, Feb 25, 2

Re: [PATCH] net: always use icmp{,v6}_ndo_send from ndo_start_xmit

2021-02-26 Thread Jason A. Donenfeld
On Sat, Feb 27, 2021 at 12:29 AM Willem de Bruijn wrote: > > On Fri, Feb 26, 2021 at 5:39 PM Jason A. Donenfeld wrote: > > > > On Fri, Feb 26, 2021 at 10:25 PM Willem de Bruijn > > wrote: > > > > > > On Thu, Feb 25, 2021 at 6:46 PM Jason A. Donenfeld > > > wrote: > > > > > > > > There were a f

Re: [PATCH] net: always use icmp{,v6}_ndo_send from ndo_start_xmit

2021-02-26 Thread Jakub Kicinski
On Fri, 26 Feb 2021 18:28:56 -0500 Willem de Bruijn wrote: > Please cc: the maintainers for patches that are meant to be merged, btw. I was about to say. Please repost.

Re: [PATCH] net: always use icmp{,v6}_ndo_send from ndo_start_xmit

2021-02-26 Thread Willem de Bruijn
On Fri, Feb 26, 2021 at 5:39 PM Jason A. Donenfeld wrote: > > On Fri, Feb 26, 2021 at 10:25 PM Willem de Bruijn > wrote: > > > > On Thu, Feb 25, 2021 at 6:46 PM Jason A. Donenfeld wrote: > > > > > > There were a few remaining tunnel drivers that didn't receive the prior > > > conversion to icmp{

Re: [PATCH] net: always use icmp{,v6}_ndo_send from ndo_start_xmit

2021-02-26 Thread Jason A. Donenfeld
On Fri, Feb 26, 2021 at 10:25 PM Willem de Bruijn wrote: > > On Thu, Feb 25, 2021 at 6:46 PM Jason A. Donenfeld wrote: > > > > There were a few remaining tunnel drivers that didn't receive the prior > > conversion to icmp{,v6}_ndo_send. Knowing now that this could lead to > > memory corrution (se

Re: [PATCH] net: always use icmp{,v6}_ndo_send from ndo_start_xmit

2021-02-26 Thread Willem de Bruijn
On Thu, Feb 25, 2021 at 6:46 PM Jason A. Donenfeld wrote: > > There were a few remaining tunnel drivers that didn't receive the prior > conversion to icmp{,v6}_ndo_send. Knowing now that this could lead to > memory corrution (see ee576c47db60 ("net: icmp: pass zeroed opts from > icmp{,v6}_ndo_send

[PATCH] net: always use icmp{,v6}_ndo_send from ndo_start_xmit

2021-02-25 Thread Jason A. Donenfeld
There were a few remaining tunnel drivers that didn't receive the prior conversion to icmp{,v6}_ndo_send. Knowing now that this could lead to memory corrution (see ee576c47db60 ("net: icmp: pass zeroed opts from icmp{,v6}_ndo_send before sending") for details), there's even more imperative to have