Re: [PATCH] net: ag71xx: fix return value check in ag71xx_probe()

2019-07-18 Thread David Miller
Please resubmit these two ag71xx patches, you use a different subsystem prefix in the Subject lines, so you should make them consistent. Using just "ag71xx: " is perfectly fine. Thank you.

Re: [PATCH] net: ag71xx: fix return value check in ag71xx_probe()

2019-07-18 Thread Oleksij Rempel
On 17.07.19 13:52, Wei Yongjun wrote: In case of error, the function of_get_mac_address() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver") Signed-off-by: Wei Yongjun

[PATCH] net: ag71xx: fix return value check in ag71xx_probe()

2019-07-17 Thread Wei Yongjun
In case of error, the function of_get_mac_address() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver") Signed-off-by: Wei Yongjun --- drivers/net/ethernet/atheros/ag71xx.c |