From: Courtney Cavin
Date: Wed, 16 Dec 2015 16:01:41 -0800
> We could hardcode the value in kconfig, but that seems like a worse
> solution than a module parameter.
>
> I'm open to further suggestions.
No module parameters, configure it via netlink or similar at run
time.
--
To unsubscribe from
On Tue, Dec 15, 2015 at 10:01:14PM +0100, David Miller wrote:
> From: Bjorn Andersson
> Date: Fri, 11 Dec 2015 12:41:59 -0800
>
> > +static unsigned int qrtr_local_nid = 1;
> > +module_param_named(node_id, qrtr_local_nid, uint, S_IRUGO);
> > +MODULE_PARM_DESC(idVendor, "Local Node Identifier");
>
On Fri, Dec 11, 2015 at 09:41:59PM +0100, Bjorn Andersson wrote:
> From: Courtney Cavin
>
> Add an implementation of Qualcomm's IPC router protocol, used to
> communicate with service providing remote processors.
>
> Signed-off-by: Courtney Cavin
> ---
[...]
> +static int qrtr_sendmsg(struct so
On Tue, 2015-12-15 at 15:13 -0600, Dan Williams wrote:
> On Tue, 2015-12-15 at 16:01 -0500, David Miller wrote:
> > From: Bjorn Andersson
> > Date: Fri, 11 Dec 2015 12:41:59 -0800
> >
> > > +static unsigned int qrtr_local_nid = 1;
> > > +module_param_named(node_id, qrtr_local_nid, uint, S_IRUGO);
On Tue, 2015-12-15 at 16:01 -0500, David Miller wrote:
> From: Bjorn Andersson
> Date: Fri, 11 Dec 2015 12:41:59 -0800
>
> > +static unsigned int qrtr_local_nid = 1;
> > +module_param_named(node_id, qrtr_local_nid, uint, S_IRUGO);
> > +MODULE_PARM_DESC(idVendor, "Local Node Identifier");
Also s/
From: Bjorn Andersson
Date: Fri, 11 Dec 2015 12:41:59 -0800
> +static unsigned int qrtr_local_nid = 1;
> +module_param_named(node_id, qrtr_local_nid, uint, S_IRUGO);
> +MODULE_PARM_DESC(idVendor, "Local Node Identifier");
Module parameters suck.
Allow the user to choose this dynamically. You h
From: Courtney Cavin
Add an implementation of Qualcomm's IPC router protocol, used to
communicate with service providing remote processors.
Signed-off-by: Courtney Cavin
---
Downstream this code also includes a large part of a service discovery
mechanism, controlled through a set of custom ioc