Re: [PATCH] net: Saner thash_entries default with much memory

2007-10-30 Thread David Miller
From: Andi Kleen <[EMAIL PROTECTED]> Date: Tue, 30 Oct 2007 21:42:05 +0100 > I still have my doubts it makes sense to have an own lock for each bucket. It > would be probably better to just divide the hash value through a factor > again and then use that to index a smaller lock only table. Yes,

Re: [PATCH] net: Saner thash_entries default with much memory

2007-10-30 Thread David Miller
From: Jean Delvare <[EMAIL PROTECTED]> Date: Tue, 30 Oct 2007 14:18:27 +0100 > OK, let's go with (512 * 1024) then. Want me to send an updated patch? Why submit a patch that's already in Linus's tree :-) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message

Re: [PATCH] net: Saner thash_entries default with much memory

2007-10-30 Thread Andi Kleen
> Next, machines that service that many sockets typically have them > mostly with full transmit queues talking to a very slow receiver at > the other end. Not sure -- there are likely use cases with lots of idle but connected sockets. Also the constraint here is not really how many sockets are

Re: [PATCH] net: Saner thash_entries default with much memory

2007-10-30 Thread Jean Delvare
Hi David, Le mardi 30 octobre 2007, David Miller a écrit : > From: Andi Kleen <[EMAIL PROTECTED]> > Date: Fri, 26 Oct 2007 17:34:17 +0200 > > > On Fri, Oct 26, 2007 at 05:21:31PM +0200, Jean Delvare wrote: > > > I propose 2 millions of entries as the arbitrary high limit. This > > > > It's proba

Re: [PATCH] net: Saner thash_entries default with much memory

2007-10-29 Thread David Miller
From: Andi Kleen <[EMAIL PROTECTED]> Date: Fri, 26 Oct 2007 17:34:17 +0200 > On Fri, Oct 26, 2007 at 05:21:31PM +0200, Jean Delvare wrote: > > I propose 2 millions of entries as the arbitrary high limit. This > > It's probably still far too large. I agree. Perhaps a better number is something o

Re: [PATCH] net: Saner thash_entries default with much memory

2007-10-26 Thread akepner
On Fri, Oct 26, 2007 at 05:21:31PM +0200, Jean Delvare wrote: > > This is just one way to limit the hash size, there are others; I am not > familiar enough with the TCP code to decide which is best. Thus, I > would welcome the proposals of alternatives. > Yeah, the existing way of sizing the

Re: [PATCH] net: Saner thash_entries default with much memory

2007-10-26 Thread Andi Kleen
On Fri, Oct 26, 2007 at 05:21:31PM +0200, Jean Delvare wrote: > I know that /proc/net/tcp is > deprecated in favor of tcp_diag, however at the moment netstat only > knows of the former. Even tcp_diag will be slow when all slots are dumped. It's a fundamental problem of the data structure. /proc ha

[PATCH] net: Saner thash_entries default with much memory

2007-10-26 Thread Jean Delvare
On systems with a very large amount of memory, the heuristics in alloc_large_system_hash() result in a very large TCP established hash table: 16 millions of entries for a 128 GB ia64 system. This makes reading from /proc/net/tcp pretty slow (well over a second) and as a result netstat is slow on th