From: Herbert Xu
Date: Sat, 22 Aug 2020 08:23:29 +1000
> The function consume_skb is only meaningful when tracing is enabled.
> This patch makes it conditional on CONFIG_TRACEPOINTS.
>
> Signed-off-by: Herbert Xu
Fair enough, applied, thanks.
On Sat, Aug 22, 2020 at 12:49:02PM -0700, David Miller wrote:
>
> From: Neil Horman
>
> Neil, you might want to fix this so people can reply to you :-)
Crap, thanks, new computer.
Neil
>
On Sat, Aug 22, 2020 at 01:54:19PM -0400, Neil Horman wrote:
>
> Wouldn't it be better to make this:
> #define consume_skb(x) kfree_skb(x)
Either way is fine but I prefer inline functions over macros.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://g
From: Neil Horman
Neil, you might want to fix this so people can reply to you :-)
On Sat, Aug 22, 2020 at 08:23:29AM +1000, Herbert Xu wrote:
> The function consume_skb is only meaningful when tracing is enabled.
> This patch makes it conditional on CONFIG_TRACEPOINTS.
>
> Signed-off-by: Herbert Xu
>
> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> index 46881
On Fri, Aug 21, 2020 at 04:40:49PM -0700, Eric Dumazet wrote:
>
> I am not completely familiar with CONFIG_TRACEPOINTS
>
> Is "perf probe" support requiring it ?
Yes.
perf probe requires CONFIG_KPROBE_EVENTS which selects CONFIG_TRACING
which selects CONFIG_TRACEPOINTS.
> We want the following
On 8/21/20 3:23 PM, Herbert Xu wrote:
> The function consume_skb is only meaningful when tracing is enabled.
> This patch makes it conditional on CONFIG_TRACEPOINTS.
>
> Signed-off-by: Herbert Xu
>
I am not completely familiar with CONFIG_TRACEPOINTS
Is "perf probe" support requiring it ?
The function consume_skb is only meaningful when tracing is enabled.
This patch makes it conditional on CONFIG_TRACEPOINTS.
Signed-off-by: Herbert Xu
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 46881d902124..e8bca74857a3 100644
--- a/include/linux/skbuff.h
+++ b/include/li
