Re: [PATCH] net: Fix the fib trie iterator to work with a single entry routing tables

2007-01-26 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Fri, 26 Jan 2007 08:42:25 -0700 > Robert Olsson <[EMAIL PROTECTED]> writes: > > > David Miller writes: > > > > > > Yes the case when the trie is just a single leaf got wrong with the > > > > iterator and your patchs cures it. I think we have a s

Re: [PATCH] net: Fix the fib trie iterator to work with a single entry routing tables

2007-01-26 Thread Eric W. Biederman
Robert Olsson <[EMAIL PROTECTED]> writes: > David Miller writes: > > > > Yes the case when the trie is just a single leaf got wrong with the > > > iterator and your patchs cures it. I think we have a similar problem > > > with /proc/net/fib_trie > > > > I'm happy to review a fix for that :-)

Re: [PATCH] net: Fix the fib trie iterator to work with a single entry routing tables

2007-01-26 Thread Robert Olsson
David Miller writes: > > Yes the case when the trie is just a single leaf got wrong with the > > iterator and your patchs cures it. I think we have a similar problem > > with /proc/net/fib_trie > > I'm happy to review a fix for that :-) When main table is just a single leaf this gets prin

Re: [PATCH] net: Fix the fib trie iterator to work with a single entry routing tables

2007-01-24 Thread Eric W. Biederman
David Miller <[EMAIL PROTECTED]> writes: > From: Robert Olsson <[EMAIL PROTECTED]> > Date: Wed, 24 Jan 2007 22:43:30 +0100 > >> Yes the case when the trie is just a single leaf got wrong with the >> iterator and your patchs cures it. I think we have a similar problem >> with /proc/net/fib_trie > >

Re: [PATCH] net: Fix the fib trie iterator to work with a single entry routing tables

2007-01-24 Thread David Miller
From: Robert Olsson <[EMAIL PROTECTED]> Date: Wed, 24 Jan 2007 22:43:30 +0100 > Yes the case when the trie is just a single leaf got wrong with the > iterator and your patchs cures it. I think we have a similar problem > with /proc/net/fib_trie I'm happy to review a fix for that :-) > Signed-off

[PATCH] net: Fix the fib trie iterator to work with a single entry routing tables

2007-01-24 Thread Robert Olsson
Hello! Yes the case when the trie is just a single leaf got wrong with the iterator and your patchs cures it. I think we have a similar problem with /proc/net/fib_trie Cheers --ro Signed-off-by: Robert Olsson <[EMAIL PROTECTED]> Eric

[PATCH] net: Fix the fib trie iterator to work with a single entry routing tables

2007-01-24 Thread Eric W. Biederman
In a kernel with trie routing enabled I had a simple routing setup with only a single route to the outside world and no default route. "ip route table list main" showed my the route just fine but /proc/net/route was an empty file. What was going on? Thinking it was a bug in something I did and I