Re: [PATCH] net: Fix for_each_netdev_feature on Big endian

2019-02-16 Thread David Miller
From: Eric Dumazet Date: Sat, 16 Feb 2019 13:01:28 -0800 > This commit added a call to fls64(), but not the needed include. > > This might break some uses I think. > > I suggest the following fix : > > diff --git a/include/linux/netdev_features.h b/include/linux/netdev_features.h > index > c5

Re: [PATCH] net: Fix for_each_netdev_feature on Big endian

2019-02-16 Thread Eric Dumazet
On 02/15/2019 08:24 PM, David Miller wrote: > From: Hauke Mehrtens > Date: Fri, 15 Feb 2019 17:58:54 +0100 > >> The features attribute is of type u64 and stored in the native endianes on >> the system. The for_each_set_bit() macro takes a pointer to a 32 bit array >> and goes over the bits in

Re: [PATCH] net: Fix for_each_netdev_feature on Big endian

2019-02-15 Thread David Miller
From: Hauke Mehrtens Date: Fri, 15 Feb 2019 17:58:54 +0100 > The features attribute is of type u64 and stored in the native endianes on > the system. The for_each_set_bit() macro takes a pointer to a 32 bit array > and goes over the bits in this area. On little Endian systems this also > works wi

[PATCH] net: Fix for_each_netdev_feature on Big endian

2019-02-15 Thread Hauke Mehrtens
The features attribute is of type u64 and stored in the native endianes on the system. The for_each_set_bit() macro takes a pointer to a 32 bit array and goes over the bits in this area. On little Endian systems this also works with an u64 as the most significant bit is on the highest address, but