Re: [PATCH] net: Add napi_sycnhronize() to sync with napi poll

2007-10-17 Thread Benjamin Herrenschmidt
On Wed, 2007-10-17 at 20:02 -0500, Josh Boyer wrote: > k, trying again, leaving the actual patch below. In the above patch > description, you still call it __napi_synchronize. In the patch > below, > it's napi_syncronize. > > I was just trying to point out to whomever commits this patch that th

Re: [PATCH] net: Add napi_sycnhronize() to sync with napi poll

2007-10-17 Thread Benjamin Herrenschmidt
> This implements a low level __napi_synchronize() function to acheive > that. The underscores are to emphasis the low level aspect of it and > to discourage driver writers who don't know what they are doing to > use it (to please DaveM :-) And I forgot to remove that bit from the description...

Re: [PATCH] net: Add napi_sycnhronize() to sync with napi poll

2007-10-17 Thread Josh Boyer
On Thu, 2007-10-18 at 08:04 +1000, Benjamin Herrenschmidt wrote: > net: Add __napi_synchronize() to sync with napi poll > > The EMAC driver which needs to handle multiple devices with one > NAPI instance implements its own per-channel disable bit. However, > when setting such a bit, it needs to sy

Re: [PATCH] net: Add napi_sycnhronize() to sync with napi poll

2007-10-17 Thread Benjamin Herrenschmidt
On Wed, 2007-10-17 at 18:36 -0500, Josh Boyer wrote: > On Thu, 2007-10-18 at 08:04 +1000, Benjamin Herrenschmidt wrote: > > net: Add __napi_synchronize() to sync with napi poll > > > > The EMAC driver which needs to handle multiple devices with one > > NAPI instance implements its own per-channel

Re: [PATCH] net: Add napi_sycnhronize() to sync with napi poll

2007-10-17 Thread Josh Boyer
On Thu, 2007-10-18 at 08:04 +1000, Benjamin Herrenschmidt wrote: > net: Add __napi_synchronize() to sync with napi poll > > The EMAC driver which needs to handle multiple devices with one > NAPI instance implements its own per-channel disable bit. However, > when setting such a bit, it needs to sy

[PATCH] net: Add napi_sycnhronize() to sync with napi poll

2007-10-17 Thread Benjamin Herrenschmidt
net: Add __napi_synchronize() to sync with napi poll The EMAC driver which needs to handle multiple devices with one NAPI instance implements its own per-channel disable bit. However, when setting such a bit, it needs to synchronize with the poller (that is make sure that any pending poller instan