Re: [PATCH] net/wan: dscc4: remove broken dscc4 driver

2019-09-16 Thread David Miller
From: Dan Carpenter Date: Fri, 13 Sep 2019 16:28:17 +0300 > Using static analysis, I discovered that the "dpriv->pci_priv->pdev" > pointer is always NULL. This pointer was supposed to be initialized > during probe and is essential for the driver to work. It would be easy > to add a "ppriv->pdev

Re: [PATCH] net/wan: dscc4: remove broken dscc4 driver

2019-09-15 Thread Francois Romieu
Dan Carpenter : > Using static analysis, I discovered that the "dpriv->pci_priv->pdev" > pointer is always NULL. This pointer was supposed to be initialized > during probe and is essential for the driver to work. It would be easy > to add a "ppriv->pdev = pdev;" to dscc4_found1() but this driver

[PATCH] net/wan: dscc4: remove broken dscc4 driver

2019-09-13 Thread Dan Carpenter
Using static analysis, I discovered that the "dpriv->pci_priv->pdev" pointer is always NULL. This pointer was supposed to be initialized during probe and is essential for the driver to work. It would be easy to add a "ppriv->pdev = pdev;" to dscc4_found1() but this driver has been broken since be