Re: [PATCH] net/tulip/xircom_cb.c: remove superfulous priv assignment

2007-08-13 Thread Jeff Garzik
Mariusz Kozlowski wrote: Hello, Unpatched version does sth like this: dev = alloc_etherdev(... private = netdev_priv(dev); ... dev->priv = private; which doesn't make much sense (does it?) because this is done in alloc_netdev() already. struct net_device *alloc_netdev(... { ...

Re: [PATCH] net/tulip/xircom_cb.c: remove superfulous priv assignment

2007-08-08 Thread Arjan van de Ven
On Wed, 2007-08-08 at 13:20 +0200, Mariusz Kozlowski wrote: > Hello, > > Unpatched version does sth like this: > > dev = alloc_etherdev(... > private = netdev_priv(dev); > ... > dev->priv = private; > > which doesn't make much sense (does it?) because this is done in > alloc_netdev() alrea

[PATCH] net/tulip/xircom_cb.c: remove superfulous priv assignment

2007-08-08 Thread Mariusz Kozlowski
Hello, Unpatched version does sth like this: dev = alloc_etherdev(... private = netdev_priv(dev); ... dev->priv = private; which doesn't make much sense (does it?) because this is done in alloc_netdev() already. struct net_device *alloc_netdev(... { ... if (sizeof_priv)