Re: [PATCH] net/ncsi: Fix re-registering ncsi device

2020-11-11 Thread Joel Stanley
On Thu, 12 Nov 2020 at 01:20, Jakub Kicinski wrote: > > On Thu, 12 Nov 2020 01:11:04 + Joel Stanley wrote: > > On Thu, 12 Nov 2020 at 00:57, Jakub Kicinski wrote: > > > > > > On Thu, 12 Nov 2020 11:10:21 +1030 Joel Stanley wrote: > > > > If a user unbinds and re-binds a ncsi aware driver, the

[PATCH] net/ncsi: Fix re-registering ncsi device

2020-11-11 Thread Joel Stanley
If a user unbinds and re-binds a ncsi aware driver, the kernel will attempt to register the netlink interface at runtime. The structure is marked __ro_after_init so this fails at this point. Unable to handle kernel paging request at virtual address 80bb588c pgd = 0ff284bb [80bb588c] *pgd=80a194

Re: [PATCH] net/ncsi: Fix re-registering ncsi device

2020-11-11 Thread Jakub Kicinski
On Thu, 12 Nov 2020 11:10:21 +1030 Joel Stanley wrote: > If a user unbinds and re-binds a ncsi aware driver, the kernel will > attempt to register the netlink interface at runtime. The structure is > marked __ro_after_init so this fails at this point. netlink family should be registered at module

Re: [PATCH] net/ncsi: Fix re-registering ncsi device

2020-11-11 Thread Jakub Kicinski
On Thu, 12 Nov 2020 01:11:04 + Joel Stanley wrote: > On Thu, 12 Nov 2020 at 00:57, Jakub Kicinski wrote: > > > > On Thu, 12 Nov 2020 11:10:21 +1030 Joel Stanley wrote: > > > If a user unbinds and re-binds a ncsi aware driver, the kernel will > > > attempt to register the netlink interface at

Re: [PATCH] net/ncsi: Fix re-registering ncsi device

2020-11-11 Thread Joel Stanley
On Thu, 12 Nov 2020 at 00:57, Jakub Kicinski wrote: > > On Thu, 12 Nov 2020 11:10:21 +1030 Joel Stanley wrote: > > If a user unbinds and re-binds a ncsi aware driver, the kernel will > > attempt to register the netlink interface at runtime. The structure is > > marked __ro_after_init so this fails