Re: [PATCH] net/mlx5e: Fix memleak in mlx5e_create_l2_table_groups

2021-01-05 Thread Saeed Mahameed
On Sun, 2020-12-27 at 10:33 +0200, Leon Romanovsky wrote: > On Mon, Dec 21, 2020 at 07:27:31PM +0800, Dinghao Liu wrote: > > When mlx5_create_flow_group() fails, ft->g should be > > freed just like when kvzalloc() fails. The caller of > > mlx5e_create_l2_table_groups() does not catch this > > issue

Re: [PATCH] net/mlx5e: Fix memleak in mlx5e_create_l2_table_groups

2020-12-27 Thread Leon Romanovsky
On Mon, Dec 21, 2020 at 07:27:31PM +0800, Dinghao Liu wrote: > When mlx5_create_flow_group() fails, ft->g should be > freed just like when kvzalloc() fails. The caller of > mlx5e_create_l2_table_groups() does not catch this > issue on failure, which leads to memleak. > > Signed-off-by: Dinghao Liu

[PATCH] net/mlx5e: Fix memleak in mlx5e_create_l2_table_groups

2020-12-21 Thread Dinghao Liu
When mlx5_create_flow_group() fails, ft->g should be freed just like when kvzalloc() fails. The caller of mlx5e_create_l2_table_groups() does not catch this issue on failure, which leads to memleak. Signed-off-by: Dinghao Liu --- drivers/net/ethernet/mellanox/mlx5/core/en_fs.c | 1 + 1 file chan