Re: [PATCH] net/mlx4_en: fix potential use-after-free with dma_unmap_page

2018-03-11 Thread Tariq Toukan
On 06/03/2018 10:16 PM, Sarah Newman wrote: On 03/06/2018 08:13 AM, Tariq Toukan wrote: I have a general question about the process. I don't totally get what branch this patch is targeted to. It touches critical areas in datapath and should go through regression tests before it is accepted t

Re: [PATCH] net/mlx4_en: fix potential use-after-free with dma_unmap_page

2018-03-06 Thread Sarah Newman
On 03/06/2018 08:13 AM, Tariq Toukan wrote: > I have a general question about the process. > I don't totally get what branch this patch is targeted to. > It touches critical areas in datapath and should go through regression tests > before it is accepted to any branch. > This one is against 4.9

Re: [PATCH] net/mlx4_en: fix potential use-after-free with dma_unmap_page

2018-03-06 Thread Tariq Toukan
On 05/03/2018 11:10 PM, Sarah Newman wrote: On 03/05/2018 02:09 AM, Tariq Toukan wrote: On 05/03/2018 6:20 AM, Sarah Newman wrote: Take an additional reference to a page whenever it is placed into the rx ring and put the page again after running dma_unmap_page. When swiotlb is in use, call

Re: [PATCH] net/mlx4_en: fix potential use-after-free with dma_unmap_page

2018-03-05 Thread Sarah Newman
On 03/05/2018 02:09 AM, Tariq Toukan wrote: > > > On 05/03/2018 6:20 AM, Sarah Newman wrote: >> Take an additional reference to a page whenever it is placed >> into the rx ring and put the page again after running >> dma_unmap_page. >> >> When swiotlb is in use, calling dma_unmap_page means that

Re: [PATCH] net/mlx4_en: fix potential use-after-free with dma_unmap_page

2018-03-05 Thread Tariq Toukan
On 05/03/2018 6:20 AM, Sarah Newman wrote: Take an additional reference to a page whenever it is placed into the rx ring and put the page again after running dma_unmap_page. When swiotlb is in use, calling dma_unmap_page means that the original page mapped with dma_map_page must still be valid

[PATCH] net/mlx4_en: fix potential use-after-free with dma_unmap_page

2018-03-04 Thread Sarah Newman
Take an additional reference to a page whenever it is placed into the rx ring and put the page again after running dma_unmap_page. When swiotlb is in use, calling dma_unmap_page means that the original page mapped with dma_map_page must still be valid, as swiotlb will copy data from its internal c