Re: [PATCH] net/irda: remove pointless assignment/check

2016-08-19 Thread David Miller
From: Vegard Nossum Date: Fri, 19 Aug 2016 18:08:57 +0200 > We've already set sk to sock->sk and dereferenced it, so if it's NULL > we would have crashed already. Moreover, if it was NULL we would have > crashed anyway when jumping to 'out' and trying to unlock the sock. > Furthermore, if we had

[PATCH] net/irda: remove pointless assignment/check

2016-08-19 Thread Vegard Nossum
We've already set sk to sock->sk and dereferenced it, so if it's NULL we would have crashed already. Moreover, if it was NULL we would have crashed anyway when jumping to 'out' and trying to unlock the sock. Furthermore, if we had assigned a different value to 'sk' we would have been calling lock_s