Re: [PATCH] net/ethernet/freescale: Fix incorrect IS_ERR_VALUE macro usages

On Tue, Nov 24, 2020 at 8:00 PM liwei (GF) wrote: > > Hi Yang, > > On 2020/11/25 6:13, Li Yang wrote: > > On Tue, Nov 24, 2020 at 3:44 PM Li Yang wrote: > >> > >> On Tue, Nov 24, 2020 at 12:24 AM Wei Li wrote: > >>> > >>> IS_ERR_VALUE macro should be used only with unsigned long type. > >>> Espe

Re: [PATCH] net/ethernet/freescale: Fix incorrect IS_ERR_VALUE macro usages

Hi Yang, On 2020/11/25 6:13, Li Yang wrote: > On Tue, Nov 24, 2020 at 3:44 PM Li Yang wrote: >> >> On Tue, Nov 24, 2020 at 12:24 AM Wei Li wrote: >>> >>> IS_ERR_VALUE macro should be used only with unsigned long type. >>> Especially it works incorrectly with unsigned shorter types on >>> 64bit m

Re: [PATCH] net/ethernet/freescale: Fix incorrect IS_ERR_VALUE macro usages

On Tue, Nov 24, 2020 at 3:44 PM Li Yang wrote: > > On Tue, Nov 24, 2020 at 12:24 AM Wei Li wrote: > > > > IS_ERR_VALUE macro should be used only with unsigned long type. > > Especially it works incorrectly with unsigned shorter types on > > 64bit machines. > > This is truly a problem for the driv

Re: [PATCH] net/ethernet/freescale: Fix incorrect IS_ERR_VALUE macro usages

On Tue, Nov 24, 2020 at 12:24 AM Wei Li wrote: > > IS_ERR_VALUE macro should be used only with unsigned long type. > Especially it works incorrectly with unsigned shorter types on > 64bit machines. This is truly a problem for the driver to run on 64-bit architectures. But from an earlier discussi

[PATCH] net/ethernet/freescale: Fix incorrect IS_ERR_VALUE macro usages

IS_ERR_VALUE macro should be used only with unsigned long type. Especially it works incorrectly with unsigned shorter types on 64bit machines. Fixes: 4c35630ccda5 ("[POWERPC] Change rheap functions to use ulongs instead of pointers") Signed-off-by: Wei Li --- drivers/net/ethernet/freescale/ucc_