Re: [PATCH] net/core: remove explicit do_softirq() from busy_poll_stop()

2017-05-27 Thread Sebastian Andrzej Siewior
On 2017-05-22 14:26:44 [-0700], Eric Dumazet wrote: > On Mon, May 22, 2017 at 12:26 PM, Sebastian Andrzej Siewior > wrote: > > Since commit 217f69743681 ("net: busy-poll: allow preemption in > > sk_busy_loop()") there is an explicit do_softirq() invocation after > > local_bh_enable() has been invo

Re: [PATCH] net/core: remove explicit do_softirq() from busy_poll_stop()

2017-05-22 Thread Eric Dumazet
On Mon, May 22, 2017 at 12:26 PM, Sebastian Andrzej Siewior wrote: > Since commit 217f69743681 ("net: busy-poll: allow preemption in > sk_busy_loop()") there is an explicit do_softirq() invocation after > local_bh_enable() has been invoked. > I don't understand why we need this because local_bh_en

[PATCH] net/core: remove explicit do_softirq() from busy_poll_stop()

2017-05-22 Thread Sebastian Andrzej Siewior
Since commit 217f69743681 ("net: busy-poll: allow preemption in sk_busy_loop()") there is an explicit do_softirq() invocation after local_bh_enable() has been invoked. I don't understand why we need this because local_bh_enable() will invoke do_softirq() once the softirq counter reached zero and we