Re: [PATCH] negative groups in netlink_setsockopt

2007-07-18 Thread Johannes Berg
On Wed, 2007-07-18 at 02:08 -0700, David Miller wrote: > From: Johannes Berg <[EMAIL PROTECTED]> > Date: Tue, 17 Jul 2007 14:26:04 +0200 > > > Reading netlink_setsockopt it's not immediately clear why there isn't a > > bug when you pass in negative numbers, the reason being that the >= > > compari

Re: [PATCH] negative groups in netlink_setsockopt

2007-07-18 Thread David Miller
From: Johannes Berg <[EMAIL PROTECTED]> Date: Tue, 17 Jul 2007 14:26:04 +0200 > Reading netlink_setsockopt it's not immediately clear why there isn't a > bug when you pass in negative numbers, the reason being that the >= > comparison is really unsigned although 'val' is signed because > nlk->ngro

[PATCH] negative groups in netlink_setsockopt

2007-07-17 Thread Johannes Berg
Reading netlink_setsockopt it's not immediately clear why there isn't a bug when you pass in negative numbers, the reason being that the >= comparison is really unsigned although 'val' is signed because nlk->ngroups is unsigned. Make 'val' unsigned too. Signed-off-by: Johannes Berg <[EMAIL PROTECT