Re: [PATCH] mwifiex: fix possible NULL dereference

2016-04-12 Thread Andy Shevchenko
On Tue, Apr 12, 2016 at 8:43 PM, Rustad, Mark D wrote: > Andy Shevchenko wrote: > >> On Mon, Apr 11, 2016 at 6:27 PM, Sudip Mukherjee >> wrote: >>> >>> From: Sudip Mukherjee >>> >>> We have a check for card just after dereferencing it. So if it is NULL >>> we have already dereferenced it before

Re: [PATCH] mwifiex: fix possible NULL dereference

2016-04-12 Thread Rustad, Mark D
Andy Shevchenko wrote: On Mon, Apr 11, 2016 at 6:27 PM, Sudip Mukherjee wrote: From: Sudip Mukherjee We have a check for card just after dereferencing it. So if it is NULL we have already dereferenced it before its check. Lets dereference it after checking card for NULL. IIUC the code doe

Re: [PATCH] mwifiex: fix possible NULL dereference

2016-04-12 Thread Andy Shevchenko
On Mon, Apr 11, 2016 at 6:27 PM, Sudip Mukherjee wrote: > From: Sudip Mukherjee > > We have a check for card just after dereferencing it. So if it is NULL > we have already dereferenced it before its check. Lets dereference it > after checking card for NULL. IIUC the code does nothing with deref

Re: [PATCH] mwifiex: fix possible NULL dereference

2016-04-11 Thread Christian Daudt
On Mon, Apr 11, 2016 at 8:27 AM, Sudip Mukherjee wrote: > > From: Sudip Mukherjee > > We have a check for card just after dereferencing it. So if it is NULL > we have already dereferenced it before its check. Lets dereference it > after checking card for NULL. > > Signed-off-by: Sudip Mukherjee

[PATCH] mwifiex: fix possible NULL dereference

2016-04-11 Thread Sudip Mukherjee
From: Sudip Mukherjee We have a check for card just after dereferencing it. So if it is NULL we have already dereferenced it before its check. Lets dereference it after checking card for NULL. Signed-off-by: Sudip Mukherjee --- drivers/net/wireless/marvell/mwifiex/pcie.c | 3 ++- 1 file change