Re: [PATCH] mpls: Do not decrement alive counter for unregister events

2017-03-13 Thread David Ahern
On 3/13/17 3:11 PM, David Ahern wrote: > On 3/13/17 5:10 AM, Robert Shearman wrote: >> Doesn't this leave the problem that if the device's link goes down and >> then the device gets deleted the alive count will be decremented twice >> for the same path? > yes. and it exposes another bug in multipat

Re: [PATCH] mpls: Do not decrement alive counter for unregister events

2017-03-13 Thread David Ahern
On 3/13/17 5:10 AM, Robert Shearman wrote: > Doesn't this leave the problem that if the device's link goes down and > then the device gets deleted the alive count will be decremented twice > for the same path? yes. and it exposes another bug in multipath selection. > > Perhaps it would be better

Re: [PATCH] mpls: Do not decrement alive counter for unregister events

2017-03-13 Thread Robert Shearman
On 10/03/17 22:11, David Ahern wrote: Multipath routes can be rendered usesless when a device in one of the paths is deleted. For example: $ ip -f mpls ro ls 100 nexthop as to 200 via inet 172.16.2.2 dev virt12 nexthop as to 300 via inet 172.16.3.2 dev br0 101 nexthop a

Re: [PATCH] mpls: Do not decrement alive counter for unregister events

2017-03-12 Thread David Miller
From: David Ahern Date: Fri, 10 Mar 2017 14:11:39 -0800 > Multipath routes can be rendered usesless when a device in one of the > paths is deleted. For example: > > $ ip -f mpls ro ls > 100 > nexthop as to 200 via inet 172.16.2.2 dev virt12 > nexthop as to 300 via inet 172.16.3.2 d

[PATCH] mpls: Do not decrement alive counter for unregister events

2017-03-10 Thread David Ahern
Multipath routes can be rendered usesless when a device in one of the paths is deleted. For example: $ ip -f mpls ro ls 100 nexthop as to 200 via inet 172.16.2.2 dev virt12 nexthop as to 300 via inet 172.16.3.2 dev br0 101 nexthop as to 201 via inet6 2000:2::2 dev virt12