Re: [PATCH] mlxsw: spectrum_router: remove redundant initialization of pointer br_dev

2020-05-26 Thread David Ahern
On 5/26/20 4:56 PM, Colin King wrote: > diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c > b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c > index 71aee4914619..8f485f9a07a7 100644 > --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c > +++ b/drivers/net/ethernet/

Re: [PATCH] mlxsw: spectrum_router: remove redundant initialization of pointer br_dev

2020-05-26 Thread Ido Schimmel
On Tue, May 26, 2020 at 11:56:49PM +0100, Colin King wrote: > From: Colin Ian King > diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c > b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c > index 71aee4914619..8f485f9a07a7 100644 > --- a/drivers/net/ethernet/mellanox/mlxsw/s

[PATCH] mlxsw: spectrum_router: remove redundant initialization of pointer br_dev

2020-05-26 Thread Colin King
From: Colin Ian King The pointer br_dev is being initialized with a value that is never read and is being updated with a new value later on. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/net/ethernet/mellanox/