Re: [PATCH] macsec: Support 32bit PN netlink attribute for XPN links

2020-08-19 Thread Era Mayflower
On Wed, Jun 24, 2020 at 10:23 AM Era Mayflower wrote: > > On Wed, Jun 17, 2020 at 1:32 AM Era Mayflower wrote: > > > > On Wed, Jun 17, 2020 at 10:02 AM Era Mayflower > > wrote: > > > > > > On Tue, Jun 16, 2020 at 1:23 AM David Miller wrote: > > > > > > > > From: Era Mayflower > > > > Date: Tu

Re: [PATCH] macsec: Support 32bit PN netlink attribute for XPN links

2020-06-24 Thread Era Mayflower
On Wed, Jun 17, 2020 at 1:32 AM Era Mayflower wrote: > > On Wed, Jun 17, 2020 at 10:02 AM Era Mayflower wrote: > > > > On Tue, Jun 16, 2020 at 1:23 AM David Miller wrote: > > > > > > From: Era Mayflower > > > Date: Tue, 16 Jun 2020 00:41:14 +0900 > > > > > > > + if (tb_sa[MACSEC_SA_ATTR_PN]

Re: [PATCH] macsec: Support 32bit PN netlink attribute for XPN links

2020-06-16 Thread Era Mayflower
On Wed, Jun 17, 2020 at 10:02 AM Era Mayflower wrote: > > On Tue, Jun 16, 2020 at 1:23 AM David Miller wrote: > > > > From: Era Mayflower > > Date: Tue, 16 Jun 2020 00:41:14 +0900 > > > > > + if (tb_sa[MACSEC_SA_ATTR_PN]) { > > > > validate_add_rxsa() requires that MACSET_SA_ATTR_PN be non-N

Re: [PATCH] macsec: Support 32bit PN netlink attribute for XPN links

2020-06-16 Thread Era Mayflower
On Tue, Jun 16, 2020 at 1:23 AM David Miller wrote: > > From: Era Mayflower > Date: Tue, 16 Jun 2020 00:41:14 +0900 > > > + if (tb_sa[MACSEC_SA_ATTR_PN]) { > > validate_add_rxsa() requires that MACSET_SA_ATTR_PN be non-NULL, so > you don't need to add this check here. > validate_add_rxsa() d

Re: [PATCH] macsec: Support 32bit PN netlink attribute for XPN links

2020-06-15 Thread David Miller
From: Era Mayflower Date: Tue, 16 Jun 2020 00:41:14 +0900 > + if (tb_sa[MACSEC_SA_ATTR_PN]) { validate_add_rxsa() requires that MACSET_SA_ATTR_PN be non-NULL, so you don't need to add this check here.

[PATCH] macsec: Support 32bit PN netlink attribute for XPN links

2020-06-15 Thread Era Mayflower
Allow using 32bit netlink attribute for packet number when creating or updating SA in an XPN link. Now utilities like iproute2's `ip` do not have to know the link type (XPN or not) when setting the packet number field of an SA. Signed-off-by: Era Mayflower --- drivers/net/macsec.c | 95 +