Re: [PATCH] mISDN: mark symbols static where possible

2016-08-31 Thread David Miller
Three different patches all with the same Subject line, so I can't apply this stuff. You must make the subject lines unique so that someone reading the "git shortlog" can tell what is different in each change.

[PATCH] mISDN: mark symbols static where possible

2016-08-29 Thread Baoyou Xie
We get 3 warnings when build kernel with W=1: drivers/isdn/hardware/mISDN/avmfritz.c:288:1: warning: no previous prototype for 'write_ctrl' [-Wmissing-prototypes] drivers/isdn/hardware/mISDN/avmfritz.c:745:1: warning: no previous prototype for 'clear_pending_hdlc_ints' [-Wmissing-prototypes] driv

Re: [PATCH] mISDN: mark symbols static where possible

2016-08-29 Thread Arnd Bergmann
On Monday 29 August 2016, Baoyou Xie wrote: > We get 1 warning when biuld kernel with W=1: > drivers/isdn/hardware/mISDN/w6692.c:851:6: warning: no previous prototype for > 'initW6692' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is declared > and don't n

[PATCH] mISDN: mark symbols static where possible

2016-08-29 Thread Baoyou Xie
We get 1 warning when build kernel with W=1: drivers/isdn/hardware/mISDN/mISDNipac.c:117:1: warning: no previous prototype for 'isac_empty_fifo' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. so

[PATCH] mISDN: mark symbols static where possible

2016-08-29 Thread Baoyou Xie
We get 1 warning when biuld kernel with W=1: drivers/isdn/hardware/mISDN/w6692.c:851:6: warning: no previous prototype for 'initW6692' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. so this patch

[PATCH] mISDN: mark symbols static where possible

2016-08-29 Thread Baoyou Xie
We get 12 warnings when biuld kernel with W=1: drivers/isdn/hardware/mISDN/hfcmulti.c:568:1: warning: no previous declaration for 'enablepcibridge' [-Wmissing-declarations] drivers/isdn/hardware/mISDN/hfcmulti.c:574:1: warning: no previous declaration for 'disablepcibridge' [-Wmissing-declaration