Re: [PATCH] mISDN: correctly handling failed allocation in fsm

2016-01-04 Thread David Miller
From: Insu Yun Date: Tue, 29 Dec 2015 16:41:33 -0500 > Since kzalloc can be failed in memory pressure, > NULL dereference can be happened. > > Signed-off-by: Insu Yun Similarly to your other mISDN patch you must propagate and handle errors properly. -- To unsubscribe from this list: send the l

Re: [PATCH] mISDN: correctly handling failed allocation

2016-01-04 Thread David Miller
From: Insu Yun Date: Tue, 29 Dec 2015 16:38:46 -0500 > Since kzalloc can be failed in memory pressure, > NULL dereference might be happened. > > Signed-off-by: Insu Yun Sorry, this is not a correct fix. You need to propagate an error back to the callers, and they must act upon that error. --

[PATCH] mISDN: correctly handling failed allocation in fsm

2015-12-29 Thread Insu Yun
Since kzalloc can be failed in memory pressure, NULL dereference can be happened. Signed-off-by: Insu Yun --- drivers/isdn/mISDN/fsm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/isdn/mISDN/fsm.c b/drivers/isdn/mISDN/fsm.c index 26477d4..3c3ffb0 100644 --- a/drivers/isdn/mISDN/

[PATCH] mISDN: correctly handling failed allocation

2015-12-29 Thread Insu Yun
Since kzalloc can be failed in memory pressure, NULL dereference might be happened. Signed-off-by: Insu Yun --- drivers/isdn/hardware/mISDN/hfcsusb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/isdn/hardware/mISDN/hfcsusb.c b/drivers/isdn/hardware/mISDN/hfcsusb.c index 114f3b