Re: [PATCH] llc: SOCK_DGRAM interface fixes

2006-08-08 Thread Arnaldo Carvalho de Melo
Em Tue, Aug 08, 2006 at 08:36:18PM +0400, Alexey Kuznetsov escreveu: > Hello! > > > This fix goes against the old historical comments about UNIX98 semantics > > but without this fix SOCK_DGRAM is broken and useless. So either ANK's > > interpretation was incorect or UNIX98 standard was wrong. > >

Re: [PATCH] llc: SOCK_DGRAM interface fixes

2006-08-08 Thread Stephen Hemminger
On Tue, 8 Aug 2006 20:36:18 +0400 Alexey Kuznetsov <[EMAIL PROTECTED]> wrote: > Hello! > > > This fix goes against the old historical comments about UNIX98 semantics > > but without this fix SOCK_DGRAM is broken and useless. So either ANK's > > interpretation was incorect or UNIX98 standard was w

Re: [PATCH] llc: SOCK_DGRAM interface fixes

2006-08-08 Thread Alexey Kuznetsov
Hello! > This fix goes against the old historical comments about UNIX98 semantics > but without this fix SOCK_DGRAM is broken and useless. So either ANK's > interpretation was incorect or UNIX98 standard was wrong. Just found this reference to me. :-) The comment migrated from tcp.c. It is only

Re: [PATCH] llc: SOCK_DGRAM interface fixes

2006-08-03 Thread David Miller
From: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> Date: Thu, 03 Aug 2006 13:38:51 -0300 > Dave, please apply. > > Acked-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> Applied, thanks everyone. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMA

Re: [stable] [PATCH] llc: SOCK_DGRAM interface fixes

2006-08-03 Thread Greg KH
On Thu, Aug 03, 2006 at 09:21:17AM -0700, Stephen Hemminger wrote: > The datagram interface of LLC is broken in a couple of ways. > These were discovered when trying to use it to build an out-of-kernel > version of STP. > > First it didn't pass the source address of the received packet > in recvfr

Re: [PATCH] llc: SOCK_DGRAM interface fixes

2006-08-03 Thread Arnaldo Carvalho de Melo
Stephen Hemminger wrote: > The datagram interface of LLC is broken in a couple of ways. I don't doubt it, most of the testing was done on the SOCK_STREAM code, Jay Schullist worked a bit on the dgram side of things but that was long ago. The plan is to use sk->sk_prot-> in the same way as the INE

[PATCH] llc: SOCK_DGRAM interface fixes

2006-08-03 Thread Stephen Hemminger
The datagram interface of LLC is broken in a couple of ways. These were discovered when trying to use it to build an out-of-kernel version of STP. First it didn't pass the source address of the received packet in recvfrom(). It needs to copy the source address of received LLC packets into the sock