Re: [stable] [PATCH] ipx: header length validation needed

2006-08-09 Thread Greg KH
On Mon, Aug 07, 2006 at 04:36:02PM -0700, Stephen Hemminger wrote: > This patch will linearize and check there is enough data. > It handles the pprop case as well as avoiding a whole audit of > the routing code. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> queued to -stable, thanks.

Re: [PATCH] ipx: header length validation needed

2006-08-07 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Mon, 7 Aug 2006 16:36:02 -0700 > This patch will linearize and check there is enough data. > It handles the pprop case as well as avoiding a whole audit of > the routing code. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied, with

Re: [PATCH] ipx: header length validation needed

2006-08-07 Thread Stephen Hemminger
This patch will linearize and check there is enough data. It handles the pprop case as well as avoiding a whole audit of the routing code. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/ipx/af_ipx.c 2006-08-07 13:45:59.0 -0700 +++ b/net/ipx/af_ipx.c 2006-08-07 16:34:00.0

Re: [PATCH] ipx: header length validation needed

2006-08-07 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Mon, 7 Aug 2006 13:46:36 -0700 > IPX is not checking for non-linear (and short packets) in it's > receive routine. This is serious because it may mean it ends up > reading past end of skb. This takes care of ipx_rcv() but the rest of the IPX prot

[PATCH] ipx: header length validation needed

2006-08-07 Thread Stephen Hemminger
IPX is not checking for non-linear (and short packets) in it's receive routine. This is serious because it may mean it ends up reading past end of skb. This maybe related to this bug, because sky2 will copy small packets into small skb's. http://bugzilla.kernel.org/show_bug.cgi?id=6693 Signe