Re: [PATCH] ipw2100: wraps the debug module param within #ifdefs

2006-04-17 Thread Stephen Hemminger
On Mon, 17 Apr 2006 10:17:43 +0800 Zhu Yi <[EMAIL PROTECTED]> wrote: > On Fri, 2006-04-14 at 09:33 -0700, Stephen Hemminger wrote: > > I meant get rid of CONFIG_IPW2200_DEBUG completely. Having the debug code > > isn't > > bad, and there is no reason not to have it always there. > > There are lo

Re: [PATCH] ipw2100: wraps the debug module param within #ifdefs

2006-04-16 Thread Zhu Yi
On Fri, 2006-04-14 at 09:33 -0700, Stephen Hemminger wrote: > I meant get rid of CONFIG_IPW2200_DEBUG completely. Having the debug code > isn't > bad, and there is no reason not to have it always there. There are lots of IPW_DEBUG_XXX in the driver, even in TX and RX paths. It cause extra cycles

Re: [PATCH] ipw2100: wraps the debug module param within #ifdefs

2006-04-14 Thread Stephen Hemminger
On Fri, 14 Apr 2006 13:18:31 +0800 Zhu Yi <[EMAIL PROTECTED]> wrote: > On Thu, 2006-04-13 at 10:30 -0700, Stephen Hemminger wrote: > > Please get rid of the debug config option. Make the debug code, default > > off and be low enough impact that everyone can ship with it. > > This patch is exactly

Re: [PATCH] ipw2100: wraps the debug module param within #ifdefs

2006-04-13 Thread Zhu Yi
On Thu, 2006-04-13 at 10:30 -0700, Stephen Hemminger wrote: > Please get rid of the debug config option. Make the debug code, default > off and be low enough impact that everyone can ship with it. This patch is exactly doing so. There won't be the debug module param if CONFIG_IPW2200_DEBUG is not

Re: [PATCH] ipw2100: wraps the debug module param within #ifdefs

2006-04-13 Thread Stephen Hemminger
Please get rid of the debug config option. Make the debug code, default off and be low enough impact that everyone can ship with it. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/major

[PATCH] ipw2100: wraps the debug module param within #ifdefs

2006-04-13 Thread Zhu Yi
Signed-off-by: Henrik Brix Andersen <[EMAIL PROTECTED]> Signed-off-by: Zhu Yi <[EMAIL PROTECTED]> --- drivers/net/wireless/ipw2100.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) e78cfdab91a809722be99c06574d2e0a60467644 diff --git a/drivers/net/wireless/ipw2100.c b/drivers/net