Re: [PATCH] ipv6 route: Aggregate table getting code

2015-10-24 Thread Masashi Honma
On 2015/10/19 15:09, David Miller wrote: This is not correct. The whole point of the test is so that the kernel log message warning for failing to provide NLM_F_CREATE can be printed in precisely the correct conditions. Thanks. Now I understand importance of the warning. Though fib6_get_table

Re: [PATCH] ipv6 route: Aggregate table getting code

2015-10-18 Thread David Miller
From: Masashi Honma Date: Sun, 18 Oct 2015 09:51:39 +0900 > These lines could be aggregated to one line because fib6_new_table() calls > fib6_get_table() inside on both cases CONFIG_IPV6_MULTIPLE_TABLES is enabled > or > not. > > Signed-off-by: Masashi Honma This is not correct. The whole po

[PATCH] ipv6 route: Aggregate table getting code

2015-10-17 Thread Masashi Honma
These lines could be aggregated to one line because fib6_new_table() calls fib6_get_table() inside on both cases CONFIG_IPV6_MULTIPLE_TABLES is enabled or not. Signed-off-by: Masashi Honma --- net/ipv6/route.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/net/ip