Re: [PATCH] ipv6: ip6mr: Recalc UDP checksum before forwarding

2017-12-13 Thread Brendan McGrath
I should clarify that the packet being forwarded originated on the Virtual Interface (i.e. it wasn't received on it). When data is received on the Virtual Interface (i.e. sent by a virtual host) then ip_summed is CHECKSUM_PARTIAL and the checksum is calculated before transmission on the wire.

Re: [PATCH] ipv6: ip6mr: Recalc UDP checksum before forwarding

2017-12-13 Thread Eric Dumazet
On Wed, 2017-12-13 at 22:20 +1100, Brendan McGrath wrote: > Currently, when forwarding from a Virtual Interface to a Physical > Interface, ip_summed is set to a value of CHECKSUM_UNNECESSARY and > the UDP checksum has not been calculated. > This seems a bug then ? CHECKSUM_UNNECESSARY means check

Re: [PATCH] ipv6: ip6mr: Recalc UDP checksum before forwarding

2017-12-13 Thread Marcelo Ricardo Leitner
Hi, On Wed, Dec 13, 2017 at 10:20:48PM +1100, Brendan McGrath wrote: > Currently, when forwarding from a Virtual Interface to a Physical > Interface, ip_summed is set to a value of CHECKSUM_UNNECESSARY and > the UDP checksum has not been calculated. > > When the packet is then forwarded by a Mult

[PATCH] ipv6: ip6mr: Recalc UDP checksum before forwarding

2017-12-13 Thread Brendan McGrath
Currently, when forwarding from a Virtual Interface to a Physical Interface, ip_summed is set to a value of CHECKSUM_UNNECESSARY and the UDP checksum has not been calculated. When the packet is then forwarded by a Multicast Router, the checksum value is left as is and therefore rejected by the rec