Re: [PATCH] ipv6/addrlabel: fix ip6addrlbl_get()

2015-12-22 Thread David Miller
From: Andrey Ryabinin Date: Mon, 21 Dec 2015 12:54:45 +0300 > ip6addrlbl_get() has never worked. If ip6addrlbl_hold() succeeded, > ip6addrlbl_get() will exit with '-ESRCH'. If ip6addrlbl_hold() failed, > ip6addrlbl_get() will use about to be free ip6addrlbl_entry pointer. > > Fix this by inverti

Re: [PATCH] ipv6/addrlabel: fix ip6addrlbl_get()

2015-12-22 Thread YOSHIFUJI Hideaki
Cong Wang wrote: > On Mon, Dec 21, 2015 at 1:54 AM, Andrey Ryabinin > wrote: >> ip6addrlbl_get() has never worked. If ip6addrlbl_hold() succeeded, >> ip6addrlbl_get() will exit with '-ESRCH'. If ip6addrlbl_hold() failed, >> ip6addrlbl_get() will use about to be free ip6addrlbl_entry pointer. >> >>

Re: [PATCH] ipv6/addrlabel: fix ip6addrlbl_get()

2015-12-21 Thread Cong Wang
On Mon, Dec 21, 2015 at 1:54 AM, Andrey Ryabinin wrote: > ip6addrlbl_get() has never worked. If ip6addrlbl_hold() succeeded, > ip6addrlbl_get() will exit with '-ESRCH'. If ip6addrlbl_hold() failed, > ip6addrlbl_get() will use about to be free ip6addrlbl_entry pointer. > > Fix this by inverting ip6

[PATCH] ipv6/addrlabel: fix ip6addrlbl_get()

2015-12-21 Thread Andrey Ryabinin
ip6addrlbl_get() has never worked. If ip6addrlbl_hold() succeeded, ip6addrlbl_get() will exit with '-ESRCH'. If ip6addrlbl_hold() failed, ip6addrlbl_get() will use about to be free ip6addrlbl_entry pointer. Fix this by inverting ip6addrlbl_hold() check. Fixes: 2a8cc6c89039 ("[IPV6] ADDRCONF: Supp