Re: [PATCH] ipset: fix a missing check of nla_parse

2019-01-10 Thread Kirill Tkhai
On 10.01.2019 01:43, Pablo Neira Ayuso wrote: > On Wed, Dec 26, 2018 at 12:16:25PM +0300, Kirill Tkhai wrote: >> On 26.12.2018 06:50, Kangjie Lu wrote: >>> When nla_parse fails, we should not use the results (the first >>> argument). The fix checks if it fails, and if so, returns its error code >>>

Re: [PATCH] ipset: fix a missing check of nla_parse

2019-01-09 Thread Pablo Neira Ayuso
On Wed, Dec 26, 2018 at 12:16:25PM +0300, Kirill Tkhai wrote: > On 26.12.2018 06:50, Kangjie Lu wrote: > > When nla_parse fails, we should not use the results (the first > > argument). The fix checks if it fails, and if so, returns its error code > > upstream. > > > > Signed-off-by: Kangjie Lu >

Re: [PATCH] ipset: fix a missing check of nla_parse

2018-12-26 Thread Kirill Tkhai
On 26.12.2018 06:50, Kangjie Lu wrote: > When nla_parse fails, we should not use the results (the first > argument). The fix checks if it fails, and if so, returns its error code > upstream. > > Signed-off-by: Kangjie Lu > --- > net/netfilter/ipset/ip_set_core.c | 4 +++- > 1 file changed, 3 ins

[PATCH] ipset: fix a missing check of nla_parse

2018-12-25 Thread Kangjie Lu
When nla_parse fails, we should not use the results (the first argument). The fix checks if it fails, and if so, returns its error code upstream. Signed-off-by: Kangjie Lu --- net/netfilter/ipset/ip_set_core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/netfilter/i