Re: [PATCH] iproute2: ip maddress: Check multiaddr length

2020-08-17 Thread Sascha Hauer
On Fri, Aug 14, 2020 at 08:27:56AM -0700, Stephen Hemminger wrote: > On Fri, 14 Aug 2020 10:46:26 +0200 > Sascha Hauer wrote: > > > ip maddress add|del takes a MAC address as argument, so insist on > > getting a length of ETH_ALEN bytes. This makes sure the passed argument > > is actually a MAC a

Re: [PATCH] iproute2: ip maddress: Check multiaddr length

2020-08-14 Thread Stephen Hemminger
On Fri, 14 Aug 2020 10:46:26 +0200 Sascha Hauer wrote: > ip maddress add|del takes a MAC address as argument, so insist on > getting a length of ETH_ALEN bytes. This makes sure the passed argument > is actually a MAC address and especially not an IPv4 address which > was previously accepted and s

[PATCH] iproute2: ip maddress: Check multiaddr length

2020-08-14 Thread Sascha Hauer
ip maddress add|del takes a MAC address as argument, so insist on getting a length of ETH_ALEN bytes. This makes sure the passed argument is actually a MAC address and especially not an IPv4 address which was previously accepted and silently taken as a MAC address. While at it, do not print *argv