Re: [PATCH] ip link/addr show: add empty line between interfaces

2015-09-07 Thread Felix Kaiser
Excerpts from Stephen Hemminger's message of 2015-09-07 11:09:32 -0700: > Agreed with Jiri. I prefer the new shorter brief format, not longer format. As long as it requires extra typing, few are going to use it. It's about the default. Did you try the brief format with a few v6 addresses on an in

Re: [PATCH] ip link/addr show: add empty line between interfaces

2015-09-07 Thread Stephen Hemminger
On Mon, 7 Sep 2015 17:54:11 +0200 Jiri Benc wrote: > On Mon, 07 Sep 2015 17:38:48 +0200, Felix Kaiser wrote: > > My opinion is that if someone parses that, they deserve the opportunity > > to fix their code. At the very least they could have used -oneline! > > No doubt. I also don't like scripts

Re: [PATCH] ip link/addr show: add empty line between interfaces

2015-09-07 Thread Jiri Benc
On Mon, 07 Sep 2015 17:38:48 +0200, Felix Kaiser wrote: > My opinion is that if someone parses that, they deserve the opportunity > to fix their code. At the very least they could have used -oneline! No doubt. I also don't like scripts that parse the default "ip a" output. I just pointed out that

Re: [PATCH] ip link/addr show: add empty line between interfaces

2015-09-07 Thread Felix Kaiser
Excerpts from Jiri Benc's message of 2015-09-07 14:46:09 +0200: > Or makes the readability worse by requiring more scrolling, depending > on number of interfaces you have and your taste. Of course it's slightly subjective, but I think it improves readability quite a bit *especially* on servers wit

Re: [PATCH] ip link/addr show: add empty line between interfaces

2015-09-07 Thread Jiri Benc
On Sun, 6 Sep 2015 13:01:09 +0200, Felix Kaiser wrote: > This improves the readability of the output. Or makes the readability worse by requiring more scrolling, depending on number of interfaces you have and your taste. Many users prefer the current format. Also, as sad as it is, there are scri

[PATCH] ip link/addr show: add empty line between interfaces

2015-09-06 Thread Felix Kaiser
This improves the readability of the output. Signed-off-by: Felix Kaiser --- ip/ip_common.h | 3 ++- ip/ipaddress.c | 11 +-- ip/iplink.c| 2 +- ip/ipmonitor.c | 2 +- 4 files changed, 13 insertions(+), 5 deletions(-) diff --git a/ip/ip_common.h b/ip/ip_common.h index f74face..c3